pre-commit hooks update; mypy, ruff fixes #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinhoyer
added
command | lint
martinhoyer
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
martinhoyer
added
the
ci | full test
martinhoyer
force-pushed
the
hooks-update
branch
from
d19371c
to
7aae691
Compare
happz
reviewed
Aug 12, 2024
happz
reviewed
Aug 12, 2024
happz
reviewed
Aug 12, 2024
happz
approved these changes
Aug 12, 2024
seberm
approved these changes
Aug 13, 2024
thrix
reviewed
Aug 13, 2024
thrix
reviewed
Aug 13, 2024
|
Please remember to rebase your changes on top of the |
thrix
approved these changes
Aug 13, 2024
No worries, he who merges is always limited to fast-forward only, therefore rebase to |
happz
added
the
status | ready for merge
happz
reviewed
Aug 13, 2024
Removing explicit container_field overloads for ConainerClass and ContainerInstance to have an unified return output. According to mypy, it would never got to the second instance of overloaded container_field, as the first one is same or broader.
Replacing regex flag aliases with full name to pass FURB167. Removing one .readlines() usage for efficiency (FURB129). Flynt f-strings checks passes, ignoring tests/unit dir.
|
Unrelated failure, merging. |
The-Mule
pushed a commit
to The-Mule/tmt
that referenced
this pull request
Oct 14, 2024
Update pre-commit hooks, update Ruff, enable flynt and refurb ruff rules and address newly found errors Removing explicit container_field overloads for ConainerClass and ContainerInstance to have a unified return output. According to mypy, it would never got to the second instance of overloaded container_field, as the first one is the same or broader. Replacing regex flag aliases with full name to pass FURB167. Removing one .readlines() usage for efficiency (FURB129). Flynt f-strings check passes, ignoring tests/unit dir. Co-authored-by: Miloš Prchlík <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New mypy version was throwing error. I've done my best to address them, but definitely needs @happz's eyes.
Refurb rules are now out of 'preview' and surprisingly, tmt passes almost everything with flying colors 🚀.
Only thing it didn't like regex flag aliases and readlines(), which was used only in one place.
Not updating to latest version of pyright. There are errors linked to UnserializeCallback, which I couldn't properly figure out.
FWIW - from https:/microsoft/pyright/releases 1.1.372: